Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for macOS #45

Merged
merged 44 commits into from
Aug 30, 2023
Merged

Add support for macOS #45

merged 44 commits into from
Aug 30, 2023

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Aug 10, 2021 •
edited
Loading

This pull request adds support for macOS.

I had to move the mode declaration from being computed in Soxin to being manually assigned in SoxinCFG. This allows us to build a system of any kind by simply set the mode input to a specific value.

Open questions

  • Is the mode the best name for this input?

SoxinCFG: kalbasit/soxincfg#20

@kalbasit kalbasit mentioned this pull request Aug 10, 2021
Closed
@kalbasit kalbasit marked this pull request as ready for review August 18, 2021 18:12
@kalbasit kalbasit requested a review from rissson August 18, 2021 18:12
rissson
rissson reviewed Aug 19, 2021
View reviewed changes
lib/system-flake.nix Outdated Show resolved Hide resolved
modules/programs/tmux/default.nix Show resolved Hide resolved
kalbasit and others added 7 commits March 19, 2022 23:39
@kalbasit
Merge remote-tracking branch 'origin/main' into personal/soxin/suppor…
7dedfd3 
…t-mac
@kalbasit
wip
5926932
@kalbasit
fix the location of modules
f97a53d
@kalbasit
fix
bfbcd86
@kalbasit
add missing sops module
3c4db9b
@kalbasit
wip
29da32f
@kalbasit
Merge remote-tracking branch 'origin/main' into personal/soxin/suppor…
d0c0c88 
…t-mac

* origin/main:
  programs.neovim: add options for RC header/footer and mapleader (#54)
  programs.rofi: dpi is an integer not a string (#53)
  rbrowser: fix the pkg on 22.05 (#52)
  soxin: inherit the plugins option as-is from home-manager (#51)
@rissson
Copy link
Member

rissson commented May 30, 2022

Is the mode the best name for this input?

Maybe backend is better?

rissson
rissson reviewed May 30, 2022
View reviewed changes
flake.nix Outdated Show resolved Hide resolved
lib/mk-flake.nix Show resolved Hide resolved
lib/mk-flake.nix Show resolved Hide resolved
template/flake.nix Show resolved Hide resolved
template/flake.nix Show resolved Hide resolved
@rissson rissson mentioned this pull request Jun 15, 2022
Open
@kalbasit
Merge branch 'main' into personal/soxin/support-mac
2430f9e 
* main:
  programs.neovim: use extraConfig instead of directly changing init.vim (#58)
  lib: mkFlake: replace devShellBuilder and packagesBuilder with outputsBuilder
  neovim: adjust homeManagerConfiguration after its 22.11 release (#56)
@kalbasit
remove stuff coming from git conflict resolve
ad882ec
@kalbasit
revert starship changes, not needed anymore
74354cf
@kalbasit
fix the template build
430c517
@kalbasit
enable zsh and set system state version
e7f94bd
@kalbasit
fmt tree
75cc555
@kalbasit kalbasit merged commit 60c6117 into main Aug 30, 2023
@kalbasit kalbasit deleted the personal/soxin/support-mac branch August 30, 2023 06:41
@rissson
Copy link
Member

rissson commented Aug 30, 2023

Did you have a look at my take on this in risson-darwin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rissson rissson rissson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalbasit @rissson